fix(ci): isolate sync parser and lease#3
Conversation
|
Cursor (@cursor) review exact commit e80435b. Please report every issue, including minor findings, or explicitly state zero issues. |
|
copilot-pull-request-reviewer review exact commit e80435b. Please report every issue, including minor findings, or explicitly state zero issues. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e80435b. Configure here.
There was a problem hiding this comment.
Pull request overview
Tightens the Upstream Sync GitHub Actions workflow to reduce race conditions during sync-branch updates and to prevent stale verifier/parser installs from leaking across runs.
Changes:
- Replaces the pre-push
git fetch+ implicit lease behavior with an explicit remote-tip read (git ls-remote) and an explicit--force-with-lease=<ref>:<expected-sha>push. - Clears
/tmp/upstream-verifierbefore installing the trusted verifier parser in thevalidatejob (matching the existingdiscover.verify_contractbehavior).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Eli Pinkerton (wallstop)
deleted the
dev/wallstop/upstream-sync-acceptance-2
branch
Summary
Verification
Note
Low Risk
CI-only changes to push leasing and temp-dir cleanup; no application runtime or auth logic is modified.
Overview
Tightens the Upstream Sync workflow so automated doc-sync pushes and contract checks are less race-prone.
On the discover job, the pre-push
git fetchof the sync branch is removed. Aftergh auth setup-git, the workflow reads the current remote tip withgit ls-remoteand force-with-lease pushes using that exact expected SHA, so a concurrent update fails the push instead of overwriting blindly.In validate, the trusted verifier install step now
rm -rf /tmp/upstream-verifierbefore recreating it, matching discover’sverify_contractbehavior so stale parser installs cannot leak across runs on the same runner.Reviewed by Cursor Bugbot for commit e80435b. Bugbot is set up for automated code reviews on this repo. Configure here.